SparePartReservationServiceTest.php 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523
  1. <?php
  2. namespace Tests\Unit\Services;
  3. use App\Models\InventoryMovement;
  4. use App\Models\Reclamation;
  5. use App\Models\Reservation;
  6. use App\Models\Shortage;
  7. use App\Models\SparePart;
  8. use App\Models\SparePartOrder;
  9. use App\Services\ReservationResult;
  10. use App\Services\ShortageService;
  11. use App\Services\SparePartReservationService;
  12. use Illuminate\Foundation\Testing\RefreshDatabase;
  13. use Tests\TestCase;
  14. class SparePartReservationServiceTest extends TestCase
  15. {
  16. use RefreshDatabase;
  17. protected $seed = true;
  18. private SparePartReservationService $service;
  19. private ShortageService $shortageService;
  20. protected function setUp(): void
  21. {
  22. parent::setUp();
  23. $this->shortageService = new ShortageService();
  24. $this->service = new SparePartReservationService($this->shortageService);
  25. }
  26. public function test_reserve_with_sufficient_stock_creates_reservation(): void
  27. {
  28. // Arrange
  29. $sparePart = SparePart::factory()->create();
  30. $reclamation = Reclamation::factory()->create();
  31. $order = SparePartOrder::factory()
  32. ->inStock()
  33. ->withDocuments(false)
  34. ->withQuantity(10)
  35. ->forSparePart($sparePart)
  36. ->create();
  37. // Act
  38. $result = $this->service->reserve(
  39. sparePartId: $sparePart->id,
  40. quantity: 5,
  41. withDocuments: false,
  42. reclamationId: $reclamation->id
  43. );
  44. // Assert
  45. $this->assertInstanceOf(ReservationResult::class, $result);
  46. $this->assertEquals(5, $result->reserved);
  47. $this->assertEquals(0, $result->missing);
  48. $this->assertTrue($result->isFullyReserved());
  49. $this->assertFalse($result->hasShortage());
  50. $this->assertCount(1, $result->reservations);
  51. // Check reservation was created in DB
  52. $this->assertDatabaseHas('reservations', [
  53. 'spare_part_id' => $sparePart->id,
  54. 'spare_part_order_id' => $order->id,
  55. 'reclamation_id' => $reclamation->id,
  56. 'reserved_qty' => 5,
  57. 'with_documents' => false,
  58. 'status' => Reservation::STATUS_ACTIVE,
  59. ]);
  60. // Check inventory movement was created
  61. $this->assertDatabaseHas('inventory_movements', [
  62. 'spare_part_id' => $sparePart->id,
  63. 'spare_part_order_id' => $order->id,
  64. 'qty' => 5,
  65. 'movement_type' => InventoryMovement::TYPE_RESERVE,
  66. 'source_type' => InventoryMovement::SOURCE_RECLAMATION,
  67. 'source_id' => $reclamation->id,
  68. ]);
  69. }
  70. public function test_reserve_with_partial_stock_creates_shortage(): void
  71. {
  72. // Arrange
  73. $sparePart = SparePart::factory()->create();
  74. $reclamation = Reclamation::factory()->create();
  75. SparePartOrder::factory()
  76. ->inStock()
  77. ->withDocuments(false)
  78. ->withQuantity(3)
  79. ->forSparePart($sparePart)
  80. ->create();
  81. // Act
  82. $result = $this->service->reserve(
  83. sparePartId: $sparePart->id,
  84. quantity: 5,
  85. withDocuments: false,
  86. reclamationId: $reclamation->id
  87. );
  88. // Assert
  89. $this->assertEquals(3, $result->reserved);
  90. $this->assertEquals(2, $result->missing);
  91. $this->assertFalse($result->isFullyReserved());
  92. $this->assertTrue($result->hasShortage());
  93. // Check shortage was created
  94. $this->assertDatabaseHas('shortages', [
  95. 'spare_part_id' => $sparePart->id,
  96. 'reclamation_id' => $reclamation->id,
  97. 'with_documents' => false,
  98. 'required_qty' => 5,
  99. 'reserved_qty' => 3,
  100. 'missing_qty' => 2,
  101. 'status' => Shortage::STATUS_OPEN,
  102. ]);
  103. }
  104. public function test_reserve_with_no_stock_creates_full_shortage(): void
  105. {
  106. // Arrange
  107. $sparePart = SparePart::factory()->create();
  108. $reclamation = Reclamation::factory()->create();
  109. // No orders created = no stock
  110. // Act
  111. $result = $this->service->reserve(
  112. sparePartId: $sparePart->id,
  113. quantity: 5,
  114. withDocuments: false,
  115. reclamationId: $reclamation->id
  116. );
  117. // Assert
  118. $this->assertEquals(0, $result->reserved);
  119. $this->assertEquals(5, $result->missing);
  120. $this->assertFalse($result->isFullyReserved());
  121. $this->assertTrue($result->hasShortage());
  122. $this->assertEmpty($result->reservations);
  123. // Check full shortage was created
  124. $this->assertDatabaseHas('shortages', [
  125. 'spare_part_id' => $sparePart->id,
  126. 'reclamation_id' => $reclamation->id,
  127. 'required_qty' => 5,
  128. 'reserved_qty' => 0,
  129. 'missing_qty' => 5,
  130. 'status' => Shortage::STATUS_OPEN,
  131. ]);
  132. }
  133. public function test_reserve_respects_fifo_order_for_multiple_batches(): void
  134. {
  135. // Arrange
  136. $sparePart = SparePart::factory()->create();
  137. $reclamation = Reclamation::factory()->create();
  138. // Create first batch (older)
  139. $olderOrder = SparePartOrder::factory()
  140. ->inStock()
  141. ->withDocuments(false)
  142. ->withQuantity(3)
  143. ->forSparePart($sparePart)
  144. ->create(['created_at' => now()->subDays(2)]);
  145. // Create second batch (newer)
  146. $newerOrder = SparePartOrder::factory()
  147. ->inStock()
  148. ->withDocuments(false)
  149. ->withQuantity(5)
  150. ->forSparePart($sparePart)
  151. ->create(['created_at' => now()->subDay()]);
  152. // Act - reserve 5 items (should use 3 from older + 2 from newer)
  153. $result = $this->service->reserve(
  154. sparePartId: $sparePart->id,
  155. quantity: 5,
  156. withDocuments: false,
  157. reclamationId: $reclamation->id
  158. );
  159. // Assert
  160. $this->assertEquals(5, $result->reserved);
  161. $this->assertCount(2, $result->reservations);
  162. // Check FIFO: first batch fully used
  163. $this->assertDatabaseHas('reservations', [
  164. 'spare_part_order_id' => $olderOrder->id,
  165. 'reserved_qty' => 3,
  166. ]);
  167. // Check FIFO: second batch partially used
  168. $this->assertDatabaseHas('reservations', [
  169. 'spare_part_order_id' => $newerOrder->id,
  170. 'reserved_qty' => 2,
  171. ]);
  172. }
  173. public function test_reserve_respects_with_documents_flag(): void
  174. {
  175. // Arrange
  176. $sparePart = SparePart::factory()->create();
  177. $reclamation = Reclamation::factory()->create();
  178. // Create batch WITHOUT documents
  179. SparePartOrder::factory()
  180. ->inStock()
  181. ->withDocuments(false)
  182. ->withQuantity(10)
  183. ->forSparePart($sparePart)
  184. ->create();
  185. // Create batch WITH documents
  186. $orderWithDocs = SparePartOrder::factory()
  187. ->inStock()
  188. ->withDocuments(true)
  189. ->withQuantity(10)
  190. ->forSparePart($sparePart)
  191. ->create();
  192. // Act - reserve WITH documents
  193. $result = $this->service->reserve(
  194. sparePartId: $sparePart->id,
  195. quantity: 5,
  196. withDocuments: true,
  197. reclamationId: $reclamation->id
  198. );
  199. // Assert - should only use batch with documents
  200. $this->assertEquals(5, $result->reserved);
  201. $this->assertCount(1, $result->reservations);
  202. $this->assertDatabaseHas('reservations', [
  203. 'spare_part_order_id' => $orderWithDocs->id,
  204. 'with_documents' => true,
  205. ]);
  206. }
  207. public function test_reserve_considers_existing_reservations(): void
  208. {
  209. // Arrange
  210. $sparePart = SparePart::factory()->create();
  211. $reclamation1 = Reclamation::factory()->create();
  212. $reclamation2 = Reclamation::factory()->create();
  213. $order = SparePartOrder::factory()
  214. ->inStock()
  215. ->withDocuments(false)
  216. ->withQuantity(10)
  217. ->forSparePart($sparePart)
  218. ->create();
  219. // Create existing active reservation for 7 items
  220. Reservation::factory()
  221. ->active()
  222. ->withQuantity(7)
  223. ->fromOrder($order)
  224. ->forReclamation($reclamation1)
  225. ->create();
  226. // Act - try to reserve 5 more (only 3 available)
  227. $result = $this->service->reserve(
  228. sparePartId: $sparePart->id,
  229. quantity: 5,
  230. withDocuments: false,
  231. reclamationId: $reclamation2->id
  232. );
  233. // Assert
  234. $this->assertEquals(3, $result->reserved);
  235. $this->assertEquals(2, $result->missing);
  236. $this->assertTrue($result->hasShortage());
  237. }
  238. public function test_cancel_for_reclamation_cancels_all_reservations(): void
  239. {
  240. // Arrange
  241. $sparePart = SparePart::factory()->create();
  242. $reclamation = Reclamation::factory()->create();
  243. $order = SparePartOrder::factory()
  244. ->inStock()
  245. ->withDocuments(false)
  246. ->withQuantity(10)
  247. ->forSparePart($sparePart)
  248. ->create();
  249. // Create reservations
  250. Reservation::factory()
  251. ->active()
  252. ->withQuantity(3)
  253. ->fromOrder($order)
  254. ->forReclamation($reclamation)
  255. ->create();
  256. Reservation::factory()
  257. ->active()
  258. ->withQuantity(2)
  259. ->fromOrder($order)
  260. ->forReclamation($reclamation)
  261. ->create();
  262. // Create shortage
  263. Shortage::factory()
  264. ->open()
  265. ->withQuantities(10, 5)
  266. ->forSparePart($sparePart)
  267. ->forReclamation($reclamation)
  268. ->withDocuments(false)
  269. ->create();
  270. // Act
  271. $cancelled = $this->service->cancelForReclamation($reclamation->id);
  272. // Assert
  273. $this->assertEquals(5, $cancelled);
  274. // Check all reservations are cancelled
  275. $this->assertDatabaseMissing('reservations', [
  276. 'reclamation_id' => $reclamation->id,
  277. 'status' => Reservation::STATUS_ACTIVE,
  278. ]);
  279. $this->assertEquals(2, Reservation::where('reclamation_id', $reclamation->id)
  280. ->where('status', Reservation::STATUS_CANCELLED)->count());
  281. // Check shortage is closed
  282. $this->assertDatabaseHas('shortages', [
  283. 'reclamation_id' => $reclamation->id,
  284. 'status' => Shortage::STATUS_CLOSED,
  285. ]);
  286. }
  287. public function test_cancel_for_reclamation_filters_by_spare_part(): void
  288. {
  289. // Arrange
  290. $sparePart1 = SparePart::factory()->create();
  291. $sparePart2 = SparePart::factory()->create();
  292. $reclamation = Reclamation::factory()->create();
  293. $order1 = SparePartOrder::factory()
  294. ->inStock()
  295. ->forSparePart($sparePart1)
  296. ->create();
  297. $order2 = SparePartOrder::factory()
  298. ->inStock()
  299. ->forSparePart($sparePart2)
  300. ->create();
  301. $reservation1 = Reservation::factory()
  302. ->active()
  303. ->withQuantity(3)
  304. ->fromOrder($order1)
  305. ->forReclamation($reclamation)
  306. ->create();
  307. $reservation2 = Reservation::factory()
  308. ->active()
  309. ->withQuantity(5)
  310. ->fromOrder($order2)
  311. ->forReclamation($reclamation)
  312. ->create();
  313. // Act - cancel only for sparePart1
  314. $cancelled = $this->service->cancelForReclamation(
  315. $reclamation->id,
  316. sparePartId: $sparePart1->id
  317. );
  318. // Assert
  319. $this->assertEquals(3, $cancelled);
  320. $this->assertDatabaseHas('reservations', [
  321. 'id' => $reservation1->id,
  322. 'status' => Reservation::STATUS_CANCELLED,
  323. ]);
  324. $this->assertDatabaseHas('reservations', [
  325. 'id' => $reservation2->id,
  326. 'status' => Reservation::STATUS_ACTIVE,
  327. ]);
  328. }
  329. public function test_get_reservations_for_reclamation_returns_active_only(): void
  330. {
  331. // Arrange
  332. $sparePart = SparePart::factory()->create();
  333. $reclamation = Reclamation::factory()->create();
  334. $order = SparePartOrder::factory()
  335. ->inStock()
  336. ->forSparePart($sparePart)
  337. ->create();
  338. Reservation::factory()
  339. ->active()
  340. ->fromOrder($order)
  341. ->forReclamation($reclamation)
  342. ->create();
  343. Reservation::factory()
  344. ->cancelled()
  345. ->fromOrder($order)
  346. ->forReclamation($reclamation)
  347. ->create();
  348. Reservation::factory()
  349. ->issued()
  350. ->fromOrder($order)
  351. ->forReclamation($reclamation)
  352. ->create();
  353. // Act
  354. $reservations = $this->service->getReservationsForReclamation($reclamation->id);
  355. // Assert
  356. $this->assertCount(1, $reservations);
  357. $this->assertEquals(Reservation::STATUS_ACTIVE, $reservations->first()->status);
  358. }
  359. public function test_adjust_reservation_increases_quantity(): void
  360. {
  361. // Arrange
  362. $sparePart = SparePart::factory()->create();
  363. $reclamation = Reclamation::factory()->create();
  364. $order = SparePartOrder::factory()
  365. ->inStock()
  366. ->withDocuments(false)
  367. ->withQuantity(20)
  368. ->forSparePart($sparePart)
  369. ->create();
  370. // Initial reservation of 5
  371. Reservation::factory()
  372. ->active()
  373. ->withQuantity(5)
  374. ->withDocuments(false)
  375. ->fromOrder($order)
  376. ->forReclamation($reclamation)
  377. ->create();
  378. // Act - increase to 10
  379. $result = $this->service->adjustReservation(
  380. reclamationId: $reclamation->id,
  381. sparePartId: $sparePart->id,
  382. withDocuments: false,
  383. newQuantity: 10
  384. );
  385. // Assert - should have reserved additional 5
  386. $this->assertEquals(5, $result->reserved);
  387. $this->assertEquals(0, $result->missing);
  388. $totalReserved = Reservation::where('reclamation_id', $reclamation->id)
  389. ->where('spare_part_id', $sparePart->id)
  390. ->where('status', Reservation::STATUS_ACTIVE)
  391. ->sum('reserved_qty');
  392. $this->assertEquals(10, $totalReserved);
  393. }
  394. public function test_adjust_reservation_decreases_quantity(): void
  395. {
  396. // Arrange
  397. $sparePart = SparePart::factory()->create();
  398. $reclamation = Reclamation::factory()->create();
  399. $order = SparePartOrder::factory()
  400. ->inStock()
  401. ->withDocuments(false)
  402. ->withQuantity(20)
  403. ->forSparePart($sparePart)
  404. ->create();
  405. // Initial reservation of 10
  406. Reservation::factory()
  407. ->active()
  408. ->withQuantity(10)
  409. ->withDocuments(false)
  410. ->fromOrder($order)
  411. ->forReclamation($reclamation)
  412. ->create();
  413. // Act - decrease to 3
  414. $result = $this->service->adjustReservation(
  415. reclamationId: $reclamation->id,
  416. sparePartId: $sparePart->id,
  417. withDocuments: false,
  418. newQuantity: 3
  419. );
  420. // Assert
  421. $this->assertEquals(3, $result->reserved);
  422. $this->assertEquals(0, $result->missing);
  423. }
  424. public function test_cancel_reservation_does_not_cancel_non_active(): void
  425. {
  426. // Arrange
  427. $sparePart = SparePart::factory()->create();
  428. $reclamation = Reclamation::factory()->create();
  429. $order = SparePartOrder::factory()
  430. ->inStock()
  431. ->forSparePart($sparePart)
  432. ->create();
  433. $reservation = Reservation::factory()
  434. ->issued()
  435. ->fromOrder($order)
  436. ->forReclamation($reclamation)
  437. ->create();
  438. // Act
  439. $result = $this->service->cancelReservation($reservation);
  440. // Assert
  441. $this->assertFalse($result);
  442. $this->assertDatabaseHas('reservations', [
  443. 'id' => $reservation->id,
  444. 'status' => Reservation::STATUS_ISSUED,
  445. ]);
  446. }
  447. }