SparePartReservationServiceTest.php 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521
  1. <?php
  2. namespace Tests\Unit\Services;
  3. use App\Models\InventoryMovement;
  4. use App\Models\Reclamation;
  5. use App\Models\Reservation;
  6. use App\Models\Shortage;
  7. use App\Models\SparePart;
  8. use App\Models\SparePartOrder;
  9. use App\Services\ReservationResult;
  10. use App\Services\ShortageService;
  11. use App\Services\SparePartReservationService;
  12. use Illuminate\Foundation\Testing\RefreshDatabase;
  13. use Tests\TestCase;
  14. class SparePartReservationServiceTest extends TestCase
  15. {
  16. use RefreshDatabase;
  17. private SparePartReservationService $service;
  18. private ShortageService $shortageService;
  19. protected function setUp(): void
  20. {
  21. parent::setUp();
  22. $this->shortageService = new ShortageService();
  23. $this->service = new SparePartReservationService($this->shortageService);
  24. }
  25. public function test_reserve_with_sufficient_stock_creates_reservation(): void
  26. {
  27. // Arrange
  28. $sparePart = SparePart::factory()->create();
  29. $reclamation = Reclamation::factory()->create();
  30. $order = SparePartOrder::factory()
  31. ->inStock()
  32. ->withDocuments(false)
  33. ->withQuantity(10)
  34. ->forSparePart($sparePart)
  35. ->create();
  36. // Act
  37. $result = $this->service->reserve(
  38. sparePartId: $sparePart->id,
  39. quantity: 5,
  40. withDocuments: false,
  41. reclamationId: $reclamation->id
  42. );
  43. // Assert
  44. $this->assertInstanceOf(ReservationResult::class, $result);
  45. $this->assertEquals(5, $result->reserved);
  46. $this->assertEquals(0, $result->missing);
  47. $this->assertTrue($result->isFullyReserved());
  48. $this->assertFalse($result->hasShortage());
  49. $this->assertCount(1, $result->reservations);
  50. // Check reservation was created in DB
  51. $this->assertDatabaseHas('reservations', [
  52. 'spare_part_id' => $sparePart->id,
  53. 'spare_part_order_id' => $order->id,
  54. 'reclamation_id' => $reclamation->id,
  55. 'reserved_qty' => 5,
  56. 'with_documents' => false,
  57. 'status' => Reservation::STATUS_ACTIVE,
  58. ]);
  59. // Check inventory movement was created
  60. $this->assertDatabaseHas('inventory_movements', [
  61. 'spare_part_id' => $sparePart->id,
  62. 'spare_part_order_id' => $order->id,
  63. 'qty' => 5,
  64. 'movement_type' => InventoryMovement::TYPE_RESERVE,
  65. 'source_type' => InventoryMovement::SOURCE_RECLAMATION,
  66. 'source_id' => $reclamation->id,
  67. ]);
  68. }
  69. public function test_reserve_with_partial_stock_creates_shortage(): void
  70. {
  71. // Arrange
  72. $sparePart = SparePart::factory()->create();
  73. $reclamation = Reclamation::factory()->create();
  74. SparePartOrder::factory()
  75. ->inStock()
  76. ->withDocuments(false)
  77. ->withQuantity(3)
  78. ->forSparePart($sparePart)
  79. ->create();
  80. // Act
  81. $result = $this->service->reserve(
  82. sparePartId: $sparePart->id,
  83. quantity: 5,
  84. withDocuments: false,
  85. reclamationId: $reclamation->id
  86. );
  87. // Assert
  88. $this->assertEquals(3, $result->reserved);
  89. $this->assertEquals(2, $result->missing);
  90. $this->assertFalse($result->isFullyReserved());
  91. $this->assertTrue($result->hasShortage());
  92. // Check shortage was created
  93. $this->assertDatabaseHas('shortages', [
  94. 'spare_part_id' => $sparePart->id,
  95. 'reclamation_id' => $reclamation->id,
  96. 'with_documents' => false,
  97. 'required_qty' => 5,
  98. 'reserved_qty' => 3,
  99. 'missing_qty' => 2,
  100. 'status' => Shortage::STATUS_OPEN,
  101. ]);
  102. }
  103. public function test_reserve_with_no_stock_creates_full_shortage(): void
  104. {
  105. // Arrange
  106. $sparePart = SparePart::factory()->create();
  107. $reclamation = Reclamation::factory()->create();
  108. // No orders created = no stock
  109. // Act
  110. $result = $this->service->reserve(
  111. sparePartId: $sparePart->id,
  112. quantity: 5,
  113. withDocuments: false,
  114. reclamationId: $reclamation->id
  115. );
  116. // Assert
  117. $this->assertEquals(0, $result->reserved);
  118. $this->assertEquals(5, $result->missing);
  119. $this->assertFalse($result->isFullyReserved());
  120. $this->assertTrue($result->hasShortage());
  121. $this->assertEmpty($result->reservations);
  122. // Check full shortage was created
  123. $this->assertDatabaseHas('shortages', [
  124. 'spare_part_id' => $sparePart->id,
  125. 'reclamation_id' => $reclamation->id,
  126. 'required_qty' => 5,
  127. 'reserved_qty' => 0,
  128. 'missing_qty' => 5,
  129. 'status' => Shortage::STATUS_OPEN,
  130. ]);
  131. }
  132. public function test_reserve_respects_fifo_order_for_multiple_batches(): void
  133. {
  134. // Arrange
  135. $sparePart = SparePart::factory()->create();
  136. $reclamation = Reclamation::factory()->create();
  137. // Create first batch (older)
  138. $olderOrder = SparePartOrder::factory()
  139. ->inStock()
  140. ->withDocuments(false)
  141. ->withQuantity(3)
  142. ->forSparePart($sparePart)
  143. ->create(['created_at' => now()->subDays(2)]);
  144. // Create second batch (newer)
  145. $newerOrder = SparePartOrder::factory()
  146. ->inStock()
  147. ->withDocuments(false)
  148. ->withQuantity(5)
  149. ->forSparePart($sparePart)
  150. ->create(['created_at' => now()->subDay()]);
  151. // Act - reserve 5 items (should use 3 from older + 2 from newer)
  152. $result = $this->service->reserve(
  153. sparePartId: $sparePart->id,
  154. quantity: 5,
  155. withDocuments: false,
  156. reclamationId: $reclamation->id
  157. );
  158. // Assert
  159. $this->assertEquals(5, $result->reserved);
  160. $this->assertCount(2, $result->reservations);
  161. // Check FIFO: first batch fully used
  162. $this->assertDatabaseHas('reservations', [
  163. 'spare_part_order_id' => $olderOrder->id,
  164. 'reserved_qty' => 3,
  165. ]);
  166. // Check FIFO: second batch partially used
  167. $this->assertDatabaseHas('reservations', [
  168. 'spare_part_order_id' => $newerOrder->id,
  169. 'reserved_qty' => 2,
  170. ]);
  171. }
  172. public function test_reserve_respects_with_documents_flag(): void
  173. {
  174. // Arrange
  175. $sparePart = SparePart::factory()->create();
  176. $reclamation = Reclamation::factory()->create();
  177. // Create batch WITHOUT documents
  178. SparePartOrder::factory()
  179. ->inStock()
  180. ->withDocuments(false)
  181. ->withQuantity(10)
  182. ->forSparePart($sparePart)
  183. ->create();
  184. // Create batch WITH documents
  185. $orderWithDocs = SparePartOrder::factory()
  186. ->inStock()
  187. ->withDocuments(true)
  188. ->withQuantity(10)
  189. ->forSparePart($sparePart)
  190. ->create();
  191. // Act - reserve WITH documents
  192. $result = $this->service->reserve(
  193. sparePartId: $sparePart->id,
  194. quantity: 5,
  195. withDocuments: true,
  196. reclamationId: $reclamation->id
  197. );
  198. // Assert - should only use batch with documents
  199. $this->assertEquals(5, $result->reserved);
  200. $this->assertCount(1, $result->reservations);
  201. $this->assertDatabaseHas('reservations', [
  202. 'spare_part_order_id' => $orderWithDocs->id,
  203. 'with_documents' => true,
  204. ]);
  205. }
  206. public function test_reserve_considers_existing_reservations(): void
  207. {
  208. // Arrange
  209. $sparePart = SparePart::factory()->create();
  210. $reclamation1 = Reclamation::factory()->create();
  211. $reclamation2 = Reclamation::factory()->create();
  212. $order = SparePartOrder::factory()
  213. ->inStock()
  214. ->withDocuments(false)
  215. ->withQuantity(10)
  216. ->forSparePart($sparePart)
  217. ->create();
  218. // Create existing active reservation for 7 items
  219. Reservation::factory()
  220. ->active()
  221. ->withQuantity(7)
  222. ->fromOrder($order)
  223. ->forReclamation($reclamation1)
  224. ->create();
  225. // Act - try to reserve 5 more (only 3 available)
  226. $result = $this->service->reserve(
  227. sparePartId: $sparePart->id,
  228. quantity: 5,
  229. withDocuments: false,
  230. reclamationId: $reclamation2->id
  231. );
  232. // Assert
  233. $this->assertEquals(3, $result->reserved);
  234. $this->assertEquals(2, $result->missing);
  235. $this->assertTrue($result->hasShortage());
  236. }
  237. public function test_cancel_for_reclamation_cancels_all_reservations(): void
  238. {
  239. // Arrange
  240. $sparePart = SparePart::factory()->create();
  241. $reclamation = Reclamation::factory()->create();
  242. $order = SparePartOrder::factory()
  243. ->inStock()
  244. ->withDocuments(false)
  245. ->withQuantity(10)
  246. ->forSparePart($sparePart)
  247. ->create();
  248. // Create reservations
  249. Reservation::factory()
  250. ->active()
  251. ->withQuantity(3)
  252. ->fromOrder($order)
  253. ->forReclamation($reclamation)
  254. ->create();
  255. Reservation::factory()
  256. ->active()
  257. ->withQuantity(2)
  258. ->fromOrder($order)
  259. ->forReclamation($reclamation)
  260. ->create();
  261. // Create shortage
  262. Shortage::factory()
  263. ->open()
  264. ->withQuantities(10, 5)
  265. ->forSparePart($sparePart)
  266. ->forReclamation($reclamation)
  267. ->withDocuments(false)
  268. ->create();
  269. // Act
  270. $cancelled = $this->service->cancelForReclamation($reclamation->id);
  271. // Assert
  272. $this->assertEquals(5, $cancelled);
  273. // Check all reservations are cancelled
  274. $this->assertDatabaseMissing('reservations', [
  275. 'reclamation_id' => $reclamation->id,
  276. 'status' => Reservation::STATUS_ACTIVE,
  277. ]);
  278. $this->assertEquals(2, Reservation::where('reclamation_id', $reclamation->id)
  279. ->where('status', Reservation::STATUS_CANCELLED)->count());
  280. // Check shortage is closed
  281. $this->assertDatabaseHas('shortages', [
  282. 'reclamation_id' => $reclamation->id,
  283. 'status' => Shortage::STATUS_CLOSED,
  284. ]);
  285. }
  286. public function test_cancel_for_reclamation_filters_by_spare_part(): void
  287. {
  288. // Arrange
  289. $sparePart1 = SparePart::factory()->create();
  290. $sparePart2 = SparePart::factory()->create();
  291. $reclamation = Reclamation::factory()->create();
  292. $order1 = SparePartOrder::factory()
  293. ->inStock()
  294. ->forSparePart($sparePart1)
  295. ->create();
  296. $order2 = SparePartOrder::factory()
  297. ->inStock()
  298. ->forSparePart($sparePart2)
  299. ->create();
  300. $reservation1 = Reservation::factory()
  301. ->active()
  302. ->withQuantity(3)
  303. ->fromOrder($order1)
  304. ->forReclamation($reclamation)
  305. ->create();
  306. $reservation2 = Reservation::factory()
  307. ->active()
  308. ->withQuantity(5)
  309. ->fromOrder($order2)
  310. ->forReclamation($reclamation)
  311. ->create();
  312. // Act - cancel only for sparePart1
  313. $cancelled = $this->service->cancelForReclamation(
  314. $reclamation->id,
  315. sparePartId: $sparePart1->id
  316. );
  317. // Assert
  318. $this->assertEquals(3, $cancelled);
  319. $this->assertDatabaseHas('reservations', [
  320. 'id' => $reservation1->id,
  321. 'status' => Reservation::STATUS_CANCELLED,
  322. ]);
  323. $this->assertDatabaseHas('reservations', [
  324. 'id' => $reservation2->id,
  325. 'status' => Reservation::STATUS_ACTIVE,
  326. ]);
  327. }
  328. public function test_get_reservations_for_reclamation_returns_active_only(): void
  329. {
  330. // Arrange
  331. $sparePart = SparePart::factory()->create();
  332. $reclamation = Reclamation::factory()->create();
  333. $order = SparePartOrder::factory()
  334. ->inStock()
  335. ->forSparePart($sparePart)
  336. ->create();
  337. Reservation::factory()
  338. ->active()
  339. ->fromOrder($order)
  340. ->forReclamation($reclamation)
  341. ->create();
  342. Reservation::factory()
  343. ->cancelled()
  344. ->fromOrder($order)
  345. ->forReclamation($reclamation)
  346. ->create();
  347. Reservation::factory()
  348. ->issued()
  349. ->fromOrder($order)
  350. ->forReclamation($reclamation)
  351. ->create();
  352. // Act
  353. $reservations = $this->service->getReservationsForReclamation($reclamation->id);
  354. // Assert
  355. $this->assertCount(1, $reservations);
  356. $this->assertEquals(Reservation::STATUS_ACTIVE, $reservations->first()->status);
  357. }
  358. public function test_adjust_reservation_increases_quantity(): void
  359. {
  360. // Arrange
  361. $sparePart = SparePart::factory()->create();
  362. $reclamation = Reclamation::factory()->create();
  363. $order = SparePartOrder::factory()
  364. ->inStock()
  365. ->withDocuments(false)
  366. ->withQuantity(20)
  367. ->forSparePart($sparePart)
  368. ->create();
  369. // Initial reservation of 5
  370. Reservation::factory()
  371. ->active()
  372. ->withQuantity(5)
  373. ->withDocuments(false)
  374. ->fromOrder($order)
  375. ->forReclamation($reclamation)
  376. ->create();
  377. // Act - increase to 10
  378. $result = $this->service->adjustReservation(
  379. reclamationId: $reclamation->id,
  380. sparePartId: $sparePart->id,
  381. withDocuments: false,
  382. newQuantity: 10
  383. );
  384. // Assert - should have reserved additional 5
  385. $this->assertEquals(5, $result->reserved);
  386. $this->assertEquals(0, $result->missing);
  387. $totalReserved = Reservation::where('reclamation_id', $reclamation->id)
  388. ->where('spare_part_id', $sparePart->id)
  389. ->where('status', Reservation::STATUS_ACTIVE)
  390. ->sum('reserved_qty');
  391. $this->assertEquals(10, $totalReserved);
  392. }
  393. public function test_adjust_reservation_decreases_quantity(): void
  394. {
  395. // Arrange
  396. $sparePart = SparePart::factory()->create();
  397. $reclamation = Reclamation::factory()->create();
  398. $order = SparePartOrder::factory()
  399. ->inStock()
  400. ->withDocuments(false)
  401. ->withQuantity(20)
  402. ->forSparePart($sparePart)
  403. ->create();
  404. // Initial reservation of 10
  405. Reservation::factory()
  406. ->active()
  407. ->withQuantity(10)
  408. ->withDocuments(false)
  409. ->fromOrder($order)
  410. ->forReclamation($reclamation)
  411. ->create();
  412. // Act - decrease to 3
  413. $result = $this->service->adjustReservation(
  414. reclamationId: $reclamation->id,
  415. sparePartId: $sparePart->id,
  416. withDocuments: false,
  417. newQuantity: 3
  418. );
  419. // Assert
  420. $this->assertEquals(3, $result->reserved);
  421. $this->assertEquals(0, $result->missing);
  422. }
  423. public function test_cancel_reservation_does_not_cancel_non_active(): void
  424. {
  425. // Arrange
  426. $sparePart = SparePart::factory()->create();
  427. $reclamation = Reclamation::factory()->create();
  428. $order = SparePartOrder::factory()
  429. ->inStock()
  430. ->forSparePart($sparePart)
  431. ->create();
  432. $reservation = Reservation::factory()
  433. ->issued()
  434. ->fromOrder($order)
  435. ->forReclamation($reclamation)
  436. ->create();
  437. // Act
  438. $result = $this->service->cancelReservation($reservation);
  439. // Assert
  440. $this->assertFalse($result);
  441. $this->assertDatabaseHas('reservations', [
  442. 'id' => $reservation->id,
  443. 'status' => Reservation::STATUS_ISSUED,
  444. ]);
  445. }
  446. }